Skip to content

Commit

Permalink
chore(deps): update rules_lint
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeagle committed Aug 14, 2024
1 parent c06bb78 commit ae4abad
Show file tree
Hide file tree
Showing 16 changed files with 331 additions and 364 deletions.
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[[shell]]
indent_style = space
indent_size = 4
2 changes: 1 addition & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ buildifier(

alias(
name = "format",
actual = "//tools:format",
actual = "//tools/format",
)

bzl_library(
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ bazel_dep(name = "rules_proto", version = "6.0.0")

####### Dev dependencies ########

bazel_dep(name = "aspect_rules_lint", version = "0.9.1", dev_dependency = True)
bazel_dep(name = "aspect_rules_lint", version = "1.0.0-rc8", dev_dependency = True)
bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True)
bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)
bazel_dep(name = "gazelle", version = "0.36.0", dev_dependency = True, repo_name = "bazel_gazelle")
Expand Down
8 changes: 0 additions & 8 deletions WORKSPACE.bzlmod
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@ load("//.github/workflows:deps.bzl", "aspect_workflows_github_actions_deps")

aspect_workflows_github_actions_deps()

# TODO: rules_lint doesn't have a way to bring deps in under bzlmod
load(
"@aspect_rules_lint//format:repositories.bzl",
"fetch_shfmt",
)

fetch_shfmt()

# Needed for stardoc to compile from Java sources
http_jar(
name = "protobuf-java",
Expand Down
18 changes: 9 additions & 9 deletions e2e/test/3p_deps.bats
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@ teardown() {
workspace --npm-translate-lock
tsconfig

echo 'export * as core from "@nestjs/core"' > source.ts
echo 'console.log("test")' >> source.ts
echo 'export * as core from "@nestjs/core"' >source.ts
echo 'console.log("test")' >>source.ts

ts_project -l -s "source.ts" -d ":node_modules/@types/node" -d ":node_modules/@nestjs/core" -d ":node_modules/@nestjs/common"
ts_project -l -s "source.ts" -d ":node_modules/@types/node" -d ":node_modules/@nestjs/core" -d ":node_modules/@nestjs/common"
run bazel build :foo
assert_success
assert_success
refute_output -p "error" "@nestjs/core" "@types/node"

# upgrade: @nestjs/core from 9.2.0 to 9.2.1
# upgrade: @nestjs/core from 9.2.0 to 9.2.1
# dowgrade: @types/node from 18.11.9 to 18.6.1
run pnpm add @nestjs/[email protected] @types/[email protected] --lockfile-only

run bazel build :foo
assert_failure
assert_output -p "error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type"

# dowgrade: @nestjs/core from 9.2.1 to 9.2.0
# upgrade: @types/node from 18.6.1 to 18.11.9
# dowgrade: @nestjs/core from 9.2.1 to 9.2.0
# upgrade: @types/node from 18.6.1 to 18.11.9
run pnpm add @nestjs/[email protected] @types/[email protected] --lockfile-only

run bazel build :foo
assert_success
assert_success
refute_output -p "error" "@nestjs/core" "@types/node"
}
}
Loading

0 comments on commit ae4abad

Please sign in to comment.