feat: py_image_layers #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
py_image_layer
branch
from
9aa43f9
to
93bd381
Compare
|
Please provide a description of the change rather than just a link to an issue. |
mattem
requested changes
Jun 17, 2024
| # match *only* external pip like repositories that contain the string "site-packages" | ||
| SITE_PACKAGES_REGEX = "\\.runfiles/.*/site-packages/.*" | ||
|
|
||
| def py_image_layers(name, binary, interpreter_regex = PY_INTERPRETER_REGEX, site_packages_regex = SITE_PACKAGES_REGEX): |
There was a problem hiding this comment.
Pass kwargs and propagate the well known tags.
| name = "say_image", | ||
| base = "@ubuntu", | ||
| entrypoint = ["/examples/py_binary/say_hello"], | ||
| tars = py_image_layers("say_image_layers", "say_hello"), |
There was a problem hiding this comment.
Could this instead produce a filegroup, so it can be used like a regular rule, rather than unexpectedly returning a list?
mattem
reviewed
Jun 17, 2024
|
|
||
| register_coreutils_toolchains() | ||
|
|
||
| register_tar_toolchains() |
There was a problem hiding this comment.
Users will also need this toolchain? Is the expectation that they register too, or should this ruleset be doing that in the setup
mattem
reviewed
Jun 17, 2024
| mtree = "{}.{}_tar_manifest".format(name, layer), | ||
| ) | ||
|
|
||
| return result |
There was a problem hiding this comment.
native.filegroup(
name = name,
srcs = results,
... tags, visibility, etc.
)
mattem
reviewed
Jun 17, 2024
| # match *only* external pip like repositories that contain the string "site-packages" | ||
| SITE_PACKAGES_REGEX = "\\.runfiles/.*/site-packages/.*" | ||
|
|
||
| def py_image_layers(name, binary, interpreter_regex = PY_INTERPRETER_REGEX, site_packages_regex = SITE_PACKAGES_REGEX): |
There was a problem hiding this comment.
interpreter_regex and site_packages_regex are unused, the constants are used in the macro below, did you mean to use them?
thesayyn
added a commit
that referenced
this pull request
Oct 4, 2024
Replaces #349 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Add `py_image_layer` macro for creating py container images. ### Test plan I will add a test in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Changes are visible to end-users: yes
A helper function to create image layers for a
py_binaryis now included.Test plan