Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bundle=false support #98

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

josephglanville
Copy link
Contributor

Implements support for disabling bundling.

Fixes #97

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

@gregmagolan gregmagolan added the enhancement New feature or request label Feb 14, 2023
@gregmagolan gregmagolan self-assigned this Feb 14, 2023
@gregmagolan gregmagolan added the wip Work-in-progress; not ready for a final review or for landing label Feb 18, 2023
@gregmagolan
Copy link
Member

Thanks for the PR. Is the use case here to use esbuild as a transpiler instead of a bundler?

@josephglanville
Copy link
Contributor Author

Essentially yes. I didn't get around to finishing this because we unfortunately chose to go a different way.

My eventual goal was to also introduce the possibility of using plugins in the esbuild wrapper too so that you can combine esbuild with Babel for instance. (specifically for handling twin-macro)

I might pick this up again eventually but for now it's unlikely I end up finishing it.

@josephglanville
Copy link
Contributor Author

I'm back to working on this. I will work on adding some tests for this feature and then mark the PR ready for review.

@gregmagolan
Copy link
Member

gregmagolan commented Oct 22, 2023

Sorry this one took so long to get it. Fell off the radar.

I rebased and added a commit to cleanup the new e2e test & fixup the providers when bundle is off. Also refactored a bit so the differeces between --bundle and --nobundle are easier to see and maintain.

Should be good to land now

@gregmagolan gregmagolan force-pushed the jpg/bundle-false branch 5 times, most recently from 14c5f87 to 764b0c2 Compare October 22, 2023 19:28
@gregmagolan gregmagolan changed the title feature: bundle=false support feat: add bundle=false support Oct 22, 2023
@gregmagolan gregmagolan removed the wip Work-in-progress; not ready for a final review or for landing label Oct 22, 2023
@gregmagolan gregmagolan merged commit 044face into aspect-build:main Oct 22, 2023
22 checks passed
@alexeagle alexeagle mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FR]: Support for bundle=false
3 participants