-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bundle=false support #98
feat: add bundle=false support #98
Conversation
d8f58fd
to
fe693f7
Compare
Thanks for the PR. Is the use case here to use esbuild as a transpiler instead of a bundler? |
Essentially yes. I didn't get around to finishing this because we unfortunately chose to go a different way. My eventual goal was to also introduce the possibility of using plugins in the esbuild wrapper too so that you can combine esbuild with Babel for instance. (specifically for handling twin-macro) I might pick this up again eventually but for now it's unlikely I end up finishing it. |
fe693f7
to
66621e6
Compare
I'm back to working on this. I will work on adding some tests for this feature and then mark the PR ready for review. |
66621e6
to
560c1fb
Compare
560c1fb
to
4ac3f90
Compare
4ac3f90
to
0d82e93
Compare
Sorry this one took so long to get it. Fell off the radar. I rebased and added a commit to cleanup the new e2e test & fixup the providers when bundle is off. Also refactored a bit so the differeces between --bundle and --nobundle are easier to see and maintain. Should be good to land now |
14c5f87
to
764b0c2
Compare
764b0c2
to
94aa0ea
Compare
Implements support for disabling bundling.
Fixes #97