refactor: put 'git archive' config in .git attributes

Makes it match bazelbuild/rules_proto#189
aspect-build · Nov 1, 2023 · a4ffe24 · a4ffe24
1 parent 044face
commit a4ffe24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1 +1,6 @@
 docs/*.md linguist-generated=true
+
+# Configuration for 'git archive'
+# see https://git-scm.com/docs/git-archive/2.40.0#ATTRIBUTES
+# Stamp the version into the archive
+esbuild/private/versions.bzl  export-subst
diff --git a/.github/workflows/release_prep.sh b/.github/workflows/release_prep.sh
@@ -9,11 +9,7 @@ TAG=${GITHUB_REF_NAME}
 PREFIX="rules_esbuild-${TAG:1}"
 ARCHIVE="rules_esbuild-$TAG.tar.gz"
 
-# Stamp the version into the archive
-cat >>.git/info/attributes <<EOF
-esbuild/private/versions.bzl  export-subst
-EOF
-
+# NB: configuration for 'git archive' is in /.gitattributes
 git archive --format=tar --prefix=${PREFIX}/ ${TAG} | gzip > $ARCHIVE
 SHA=$(shasum -a 256 $ARCHIVE | awk '{print $1}')