Esbuild bench #3
Conversation
dzbarsky
force-pushed
the
esbuild_bench
branch
from
e725954
to
24a1970
Compare
|
Nice. Thanks for the PR. Can you rebase? The rules_ts benchmark now runs on CI so it will exercise the new code. |
|
Sure, but it depends on aspect-build/rules_esbuild#62. Would you recommend pointing the |
Sure. That will work. Its pointing to an unlanded branch of rules_swc as well. @jbedred or I will review #62 when we have some time. |
dzbarsky
force-pushed
the
esbuild_bench
branch
from
24a1970
to
59926f8
Compare
|
OK, done. I think you need to approve the workflow since I'm a first-time contributor so we can make sure CI is happy |
|
Looks like CI is broken for PRs from forks because of EngFlow RBE configuration. I'll test this locally instead. You'll have rebase some more as I landed some changes created merge conflicts. |
|
@dzbarsky Just wanted to check-in to see if you would like to get this PR merged. If so, could you do a rebase and let us know? |
|
It was just a proof-of-concept, I'm ok abandoning it. |
This depends on a change to the esbuild rules that exposes the transpiler