Regex fix example added #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with - and / i.e. fix-ci ci/cd
…with - and / i.e. fix-ci ci/cd
|
Just pinging this PR to see where it is at in the approval process. Thank you for your help! Cheers 🎉 |
arvinxx
requested changes
Mar 10, 2024
packages/parser-opts/src/index.ts
Outdated
|
|
||
| const gitmojiCodeStr = gitmojiCodeRegex.source; | ||
| const gitmojiUnicodeStr = gitmojiUnicodeRegex.source; | ||
| const emojiStr = emojiRegex.source; | ||
|
|
||
| export default { | ||
| // Test URL: https://regex101.com/r/gYkG99/1 | ||
| // Test URL: https://regex101.com/r/HYr6d3/1 |
There was a problem hiding this comment.
Please add some more test examples to show the difference between before and after.
There was a problem hiding this comment.
I added these two lines at the bottom:
:green_heart: fix-ci(ci/cd): added release rules for all cz-emojis
:green_heart: ci/cd(config): changed config for cz-emojis
Here is the new URL: https://regex101.com/r/WXbn1P/1
Not sure I can show a before match in the same link.
Let me know if this is enough.
Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made the regex fix as well as updated the regex101 example link
also formatted my commit message with the bug emoji.