Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC plugin getOidcInstance() logic #1882

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

sbreker
Copy link
Member

@sbreker sbreker commented Oct 21, 2024

Fixed issue with arOidc::getOidcInstance() where if it were called a second time getOidcInstance() would return null instead of an instance of OpenIDConnectClient.

@sbreker sbreker requested a review from a team October 21, 2024 22:25
Copy link
Contributor

@melaniekung melaniekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sbreker !

Fix issue with arOidc::getOidcInstance() where if it were called a
second time getOidcInstance() would return null instead of an instance
of OpenIDConnectClient.
@sbreker sbreker merged commit c22ac22 into qa/2.x Oct 28, 2024
6 checks passed
@sbreker sbreker deleted the dev/oidc-instance-check branch October 28, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants