Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shfmt to format shell programs #766

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Use shfmt to format shell programs #766

merged 1 commit into from
Nov 11, 2023

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Nov 10, 2023

shfmt provides linting and formatting of shell scripts.

djjuhasz
djjuhasz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sevein sevein force-pushed the dev/shfmt branch 2 times, most recently from 1598505 to 978fc28 Compare November 11, 2023 08:22
@sevein
Copy link
Contributor Author

sevein commented Nov 11, 2023

Apparently shfmt only uses exit codes to signal errors when combined with the --diff flag, so I added it to the make target.

@sevein sevein merged commit 2c6815d into main Nov 11, 2023
11 checks passed
@sevein sevein deleted the dev/shfmt branch November 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djjuhasz djjuhasz djjuhasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevein @djjuhasz