Set default value for storage taskqueue #765
Conversation
Fixes issue #759. - Also fix SetDefault key for setting a3m.processing defaults - Add config test to confirm default values are set - Reorder embedded configs alphabetically - Log detailed error when storage.InitStorageUploadWorkflow fails
|
I was confused for a second because there were differently profile pictures haha. |
There was a problem hiding this comment.
Nice! I have a couple of thoughts:
- Was it hard to identify the root issue, David? Yesterday I only had time to reproduce the issue before I had to move to something else, but I remember seeing a cryptic uninmplemented gRPC error code, I guess because the worker was not listening on the expected task queue. If there is a learning here on how to diagnose these kind of issues I'd be happy to capture it in our docs.
- @Diogenesoftoronto now I understand what was going on behind this line change... 😆
Hopefully we can build some high-level end-to-end tests soon to identify this kind of regression before the code is merged.
|
@sevein the biggest barrier to identifying the root problem was that I was getting a very generic "cannot perform operation" from the Which is why I added error logging here: https://github.com/artefactual-sdps/enduro/blob/main/internal/storage/service.go#L125 I don't know if the error message is very general on purpose to avoid leaking implementation details to the caller, or if it's just a poorly written error message. I assumed the error message was intentionally vague and added the logging to provide additional context to the system adminstrators. |
Fixes issue #759.