Make preservation system configurable #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
requested changes
Nov 6, 2023
djjuhasz
requested changes
Nov 7, 2023
djjuhasz
requested changes
Nov 8, 2023
There was a problem hiding this comment.
A few more change request @Diogenesoftoronto. Almost there. :)
Diogenesoftoronto
force-pushed
the
dev/am-config-preservation
branch
from
8b9c5f6
to
6efc884
Compare
Diogenesoftoronto
force-pushed
the
dev/am-workflow
branch
from
833dac3
to
92cd26e
Compare
|
the last two commits add comment and remove variable are the only important changes. I just did some rebasing on main. |
djjuhasz
requested changes
Nov 8, 2023
There was a problem hiding this comment.
@Diogenesoftoronto the a3m worker task queue still needs to be changed.
djjuhasz
approved these changes
Nov 8, 2023
This commit includes several updates and improvements to the preservation system. The changes are summarized as follows: - Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility. These changes aim to enhance the functionality and maintainability of the preservation system.
Diogenesoftoronto
force-pushed
the
dev/am-config-preservation
branch
from
586f270
to
dc33150
Compare
djjuhasz
pushed a commit
that referenced
this pull request
Nov 9, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 9, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 9, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 14, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 20, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 20, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 20, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
djjuhasz
pushed a commit
that referenced
this pull request
Nov 20, 2023
- Hardcoded the a3m taskqueue name for better efficiency and optimization. - Added comments to enhance code readability and understanding. - Removed unnecessary variable to improve code clarity. - Modified names for better consistency and clarity. - Removed a comment that was no longer relevant. - Created a preservation config struct to make the system more configurable and adaptable. - Implemented configuration options for the preservation system to allow customization and flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change exists to allow for the taskqueue to determine whether or not to use archivematica or not. This could be done in a different way than the current option which is to set the preservation system variable to the a3m taskqueue. I think that simply using the taskqueue variable was a little awkward since it was tide to the a3m configuration struct. I think perhaps changing the a3m struct to a more general purpose preservation system struct or creating a new preservation struct may be more useful.