Fix API ABAC for access tokens without attributes #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we return an empty slice of attributes in the claim if no Enduro attributes are found in the token after parsing, filtering and mapping roles. A nil attributes slice is considered as ABAC disabled in the API endpoints check.
jraddaoui
commented
Nov 14, 2024
| @@ -1284,7 +1284,6 @@ func (w *ProcessingWorkflow) validatePREMIS( | |||
| XMLPath: xmlPath, | |||
| XSDPath: w.cfg.ValidatePREMIS.XSDPath, | |||
| }).Get(activityOpts, &xmlvalidateResult) | |||
|
|
|||
There was a problem hiding this comment.
Added by make lint, I didn't want to create another commit just for it ;)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 54.66% 54.73% +0.07%
==========================================
Files 104 104
Lines 7632 7631 -1
==========================================
+ Hits 4172 4177 +5
+ Misses 3202 3198 -4
+ Partials 258 256 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we return an empty slice of attributes in the claim if no Enduro attributes are found in the token after parsing, filtering and mapping roles. A nil attributes slice is considered as ABAC disabled in the API endpoints check.
Refs #1066.