Copy premis.xsd into enduro image #1064
Merged
+23
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
commented
Nov 13, 2024
| COPY --from=build-enduro --link /src/enduro.toml /home/enduro/.config/enduro.toml | ||
| COPY --link --from=build-enduro /out/enduro /home/enduro/bin/enduro | ||
| COPY --link --from=build-enduro /src/enduro.toml /home/enduro/.config/enduro.toml | ||
| COPY --link hack/xsd/premis.xsd /home/enduro/premis.xsd |
There was a problem hiding this comment.
This line is the main diff, all others are just adding missing --link to the COPY layers and reorganizing them a little.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
- Coverage 54.74% 54.66% -0.08%
==========================================
Files 104 104
Lines 7632 7632
==========================================
- Hits 4178 4172 -6
- Misses 3198 3202 +4
- Partials 256 258 +2 ☔ View full report in Codecov by Sentry. |
|
We should try to find a better solution to how we deal with the single configuration for multiple commands in distributed environments, but this makes PREMIS validation work for now in the dev environment. Other deployments are running everything together, so it shouldn't be an issue there. |
This file should only be needed by the AM and a3m workers to do PREMIS validation when it's enabled. However, config validation is the same for all commands and, when PREMIS validation is enabled, it checks the existence of the XSD file in the filesystem. We tried to disable PREMIS validation only in the enduro container, but that config value is read in the workflow context, disabling the scheduling of the activity from the workflow worker.
jraddaoui
force-pushed
the
dev/issue-951-enable-premis
branch
from
9af5acb
to
72ffd6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file should only be needed by the AM and a3m workers to do PREMIS validation when it's enabled. However, config validation is the same for all commands and, when PREMIS validation is enabled, it checks the existence of the XSD file in the filesystem. We tried to disable PREMIS validation only in the enduro container, but that config value is read in the workflow context, disabling the scheduling of the activity from the workflow worker.
Refs #951.