Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tempo metrics generator #1047

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Enable Tempo metrics generator #1047

merged 5 commits into from
Nov 4, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Oct 16, 2024

This pull request installs Prometheus in the development environment so we can start capturing application metrics (as opposed to logs or traces). It also enables the metrics generator in Grafana Tempo, which is a mechanism that derives metrics from ingested traces and store them in Prometheus. These metrics are useful in a couple of main ways: span metrics and service graphs.

The Prometheus datasource in Grafana has been configured with exemplars enabled, so you should be able to associate trace data with metric data, something that we can start exploring further once we start producing application metrics.

I've updated the dashboard with a simple service view panel:

image

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.44%. Comparing base (ea92327) to head (99b7eb5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   54.47%   54.44%   -0.03%     
==========================================
  Files         103      103              
  Lines        7510     7510              
==========================================
- Hits         4091     4089       -2     
- Misses       3169     3170       +1     
- Partials      250      251       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks @sevein!

hack/kube/components/dev/grafana-alloy.yaml Outdated Show resolved Hide resolved
@sevein sevein force-pushed the dev/tempo-metrics-generator branch from f3b1bc4 to 2864e8f Compare November 4, 2024 10:09
@sevein sevein force-pushed the dev/tempo-metrics-generator branch from 2864e8f to 99b7eb5 Compare November 4, 2024 10:10
@sevein sevein merged commit 3771b0a into main Nov 4, 2024
14 checks passed
@sevein sevein deleted the dev/tempo-metrics-generator branch November 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants