Check PREMIS validity after preprocessing

[mcantelon]

Refs #951.

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 42 lines in your changes missing coverage. Please review.

Project coverage is 54.48%. Comparing base (f924713) to head (51f39fa).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/workflow/processing.go	52.11%	27 Missing and 7 partials ⚠️
cmd/enduro-a3m-worker/main.go	0.00%	4 Missing ⚠️
cmd/enduro-am-worker/main.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   54.51%   54.48%   -0.03%     
==========================================
  Files         103      104       +1     
  Lines        7510     7602      +92     
==========================================
+ Hits         4094     4142      +48     
- Misses       3166     3202      +36     
- Partials      250      258       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jraddaoui]

Thanks @mcantelon! Check my comments below.

[jraddaoui]

Pretty close, thanks @mcantelon!

[mcantelon]

This should be ready for another review. Thanks!

[jraddaoui]

Thanks @mcantelon! Just a minor cleanup missed from the last feedback, to not increase a lot the workflow tests length.

[jraddaoui]

And for the failing check just run make golines.

[mcantelon]

Thanks again @Radda! Ready for another look!

[jraddaoui]

Thanks @mcantelon!

To save 15 more line in the tests, we could remove the default PREMIS config from them. Make sure you squash and change the commit message, maybe "before preservation" works better than "after preprocessing" now.

[jraddaoui]

Same.

[mcantelon]

Thanks @jraddaoui !