Bionic support + minor flexibility improvements #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 18.04 (Bionic) support
Upstream hasn't published the PPA repo for Bionic (hlandau/acmetool#307), so acquiring it fails on Bionic. However, quoting the readme:
This means it should be safe to always use Xenial.
Nginx assumptions lessened
Not all nginx installations (e.g. those installed with https://github.com/nginxinc/ansible-role-nginx) have a
sites-available
/sites-enabled
directory, so if theacmetool_nginx_sites_filename
variable is emptied, no files are attempted to be written there.First-class support for webroot
Webroot is now a more first-class supported method, as the path variable is exposed and can thus be used in a custom (no-magic) nginx config.