Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bionic support + minor flexibility improvements #14

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

akx
Copy link
Contributor

@akx akx commented Oct 1, 2018

Ubuntu 18.04 (Bionic) support

Upstream hasn't published the PPA repo for Bionic (hlandau/acmetool#307), so acquiring it fails on Bionic. However, quoting the readme:

(Note: There is no difference between the .deb files for different Ubuntu release codenames; they are interchangeable and completely equivalent.)

This means it should be safe to always use Xenial.

Nginx assumptions lessened

Not all nginx installations (e.g. those installed with https://github.com/nginxinc/ansible-role-nginx) have a sites-available/sites-enabled directory, so if the acmetool_nginx_sites_filename variable is emptied, no files are attempted to be written there.

First-class support for webroot

Webroot is now a more first-class supported method, as the path variable is exposed and can thus be used in a custom (no-magic) nginx config.

@hakamine
Copy link
Member

hakamine commented Oct 2, 2018

@akx thank you very much for your contribution! Did a quick test and looks good. Will merge. 👍

@hakamine hakamine merged commit e4e7cdc into artefactual-labs:master Oct 2, 2018
@akx akx deleted the flex branch October 3, 2018 06:26
@akx akx restored the flex branch October 3, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants