-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#119): add new home for configuration files #144
Changes from 6 commits
cb5a4da
7cb818a
a2c1115
96604b8
5e2f45c
c32f52a
64e63f2
3acc1b8
6ec0087
e4eb40c
1d3531f
fb4f0d4
9b05d43
4f6d727
5ccc521
3b3efa4
1821514
1f3d490
bf096fd
fd03a90
61fff53
12a8d5e
f6e7fea
cca4a27
5e5bd42
d584a4b
1530326
9fd8d2e
317e2f8
264f938
6b6d360
856bd0a
78a84b4
4611126
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
skip_validation_for: | ||
- 'cluster/' | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,7 @@ skip_validation_for: | |
## Docker | ||
- 'regex{{docker-compose.*\.y[a]?ml$}}' | ||
- 'Dockerfile*' | ||
- '.dockerignore' | ||
|
||
## Others | ||
- 'Makefile' | ||
|
@@ -134,3 +135,4 @@ skip_validation_for: | |
|
||
# Our own configurations | ||
- 'regex{{test-keeper\.y[a]?ml$}}' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this line still necessary when the configs should be inside of the directory that is excluded? |
||
- '.ike-prow/' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,12 @@ type LoadableConfig struct { | |
BaseConfig *config.PluginConfiguration | ||
} | ||
|
||
// Sources provides default loading strategies for a plugin looking it up in the root of the repository for a given | ||
// Sources provides default loading strategies for a plugin looking it up in the .ike-prow directory of the repository for a given | ||
// revision. Two files are expected to be found there plugin-name.yml or plugin-name.yaml (in that order) | ||
func (l *LoadableConfig) Sources() []config.Source { | ||
return []config.Source{ | ||
l.loadFromRawFile("%s.yml"), | ||
l.loadFromRawFile("%s.yaml"), | ||
l.loadFromRawFile(".ike-prow/%s.yml"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make |
||
l.loadFromRawFile(".ike-prow/%s.yaml"), | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is still also the original file https://github.com/dipak-pawar/ike-prow-plugins/blob/c32f52a822cedb073f21298dda3e98ecb424bf82/test-keeper.yaml - it should be removed (moved here)