Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default date and time the the compile date/time #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgtm98
Copy link

@mgtm98 mgtm98 commented Mar 5, 2020

The default date and time is the compile date/time rather than 1/1/2000.
the issue was by @tigoe (#53 (comment))

@drewfish
Copy link

drewfish commented Dec 2, 2020

This is a neat idea.

To make it more efficient perhaps it could use char * instead of String. I added a String ctor and substring() call to a test sketch and it seemed to increase the elf size by 386 bytes (for the various String methods that were not stripped out).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 2, 2022
@per1234 per1234 linked an issue May 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to set time from compiler time
4 participants