Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NTPServerSync before getNetworkTime #22

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add NTPServerSync before getNetworkTime #22

merged 2 commits into from
Jun 4, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jun 3, 2024

Calling getNetworkTime without NTPServerSync returns some weird time values in the past

1388591169 -> Wed Jan 01 2014 15:46:09 GMT+0000

Adding NTPServerSync call solves this issue

@pennam pennam requested review from sebromero and cristidragomir97 and removed request for sebromero June 3, 2024 10:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Memory usage change @ cf8c0e3

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

sebromero
sebromero requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the return code of NTPServerSync. -1 indicates an error. Maybe we can return UNIX time Time(1970,1,1,0,0,0,0) in that case.

@pennam pennam requested a review from sebromero June 3, 2024 14:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Memory usage change @ 5f9ad4c

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

sebromero
sebromero reviewed Jun 3, 2024
View reviewed changes
src/ArduinoCellular.cpp Outdated
float tz;
modem.getNetworkTime(&year, &month, &day, &hour, &minute, &second, &tz);
if (modem.NTPServerSync()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (modem.NTPServerSync()) {
if (modem.NTPServerSync() == 0) {

I think a return code of 0 indicates success. @cristidragomir97 can you double check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, i was for sure wrong. I've changed it checking if != -1 to be on the safe side 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pennam I think that -1 is the generic error code while there are other +CNTP: result codes that indicate an error. I'd check for == 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebromero Thanks! I was wrong again 🥲

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Memory usage change @ b53f899

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Memory usage change @ 94aeac0

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

sebromero
sebromero approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero sebromero merged commit 34c49f4 into arduino-libraries:main Jun 4, 2024
6 checks passed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

@cristidragomir97 cristidragomir97 Awaiting requested review from cristidragomir97

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pennam @sebromero @per1234