-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sendSMS function #15
Conversation
Fixes an error in the sendSMS function that made it impossible to send SMS.
Memory usage change @ 740c109
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @WolfRorDev, thanks for your contribution. In the begin method there's already a line that sets the SMS module into GSM mode, by sending "+CMGF=1", and this worked for me on both (EMEA and Global) modems. Could you please tell me which one you are using ? I'll investigate if the +CMGF=1 from the initialization is overridden by something, and then merge your request based on the result.
modem.sendAT("+CMGF=1"); | ||
modem.waitResponse(1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module is already set to text mode in the .begin() function.
Arduino_Cellular/src/ArduinoCellular.cpp
Lines 30 to 32 in 414d5e3
// Set GSM module to text mode | |
modem.sendAT("+CMGF=1"); | |
modem.waitResponse(); |
@cristidragomir97 would setting the text format again here increase the stability of the library?
Hey, I'm using the Global modem together with Arduino Portenta C33. I conducted many tests and found that I need to send the
The modem was tested in Poland 🇵🇱 using a SIM card from Orange Flex. |
After extensive testing, I can confirm that the fix provided here increases the stability of texts, when used together with the Pro 4G EMEA module and the Portenta C33 with a Telenor SIM Card in Sweden 🇸🇪 (only this configuration). All texts go through, when patch provided by @WolfRorDev is applied. |
Fixes an error in the sendSMS function that made it impossible to send SMS.