Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google): improve AVD-GCP-0012 rule #53

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

nikpivkin
Copy link
Collaborator

@nikpivkin nikpivkin commented Nov 15, 2023

Fixes aquasecurity/trivy#5456

We do not need to check the google_dns_keys data source because we do not know the attributes of the data sources when scanning. default_key_specs is of list type, so we must analyse all blocks.

Related PRs:

@nikpivkin
Copy link
Collaborator Author

@simar7 I will update the schema and documentation after the merger of other PRs

@nikpivkin nikpivkin marked this pull request as ready for review November 22, 2023 18:51
@simar7 simar7 merged commit 0cb0329 into aquasecurity:main Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some problems with rule AVD-GCP-0012
2 participants