Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comp/ne district #32

Merged
merged 19 commits into from
Apr 12, 2024
Merged

Comp/ne district #32

merged 19 commits into from
Apr 12, 2024

Conversation

gordonbchen
Copy link
Contributor

Description

Changes from ne district champs.

  • update shoulder autoaim fit
  • update shoulder zero angle
  • tune trap score angle and raise elevator max extension
  • add higher shoulder raise to prevent damaging shoulder on trap score

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue, add DEF # above in description)
  • Environment change (changes to developer environment or CI configuration)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Tested at NE district champs.

Author Checklist:

  • I have performed a self-review of my code
  • I have added 1-2 reviewers
  • I have @mentioned relevant non-reviewers as an FYI
  • I have included a detailed description of my changes and their motivations

Copy link
Contributor

@CJc318 CJc318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All features work in testing, no problems that I can see. may need to adjust shooting angles for fields at worlds but other than that everything is good 👍

@CJc318 CJc318 merged commit a61db0a into main Apr 12, 2024
1 check passed
@gordonbchen gordonbchen deleted the comp/ne_district branch April 14, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants