Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shoulder subsystem #17

Merged
merged 7 commits into from
Feb 10, 2024
Merged

Shoulder subsystem #17

merged 7 commits into from
Feb 10, 2024

Conversation

gordonbchen
Copy link
Contributor

Description

Add the shoulder subsystem

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue, add DEF # above in description)
  • Environment change (changes to developer environment or CI configuration)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Tested by running shoulder and watching shoulder angle on shuffleboard.

Author Checklist:

  • I have performed a self-review of my code
  • I have added 1-2 reviewers
  • I have @mentioned relevant non-reviewers as an FYI
  • I have included a detailed description of my changes and their motivations

wubbasauce
wubbasauce approved these changes Feb 10, 2024
View reviewed changes
Copy link

@wubbasauce wubbasauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gordonbchen gordonbchen merged commit fa5628d into main Feb 10, 2024
1 check passed
@gordonbchen gordonbchen deleted the gordon/feat/shoulder branch February 10, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wubbasauce wubbasauce wubbasauce approved these changes

@SuitedMoose SuitedMoose Awaiting requested review from SuitedMoose

@CJc318 CJc318 Awaiting requested review from CJc318

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gordonbchen @wubbasauce