Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some OpenAPI docs, usually through imperfect conversion from another representation, end up with duplicate raw values in
enum
schemas.The OpenAPI specification (by referencing the JSON Schema specification) says:
So elements should be unique, but don't have to be. Today the generator fails to generate documents with such duplicate values.
Modifications
Gracefully handle duplicate values by emitting a warning diagnostic and skipping it.
Result
This unblocks generating OpenAPI documents with duplicate enum values, such as the Bluesky OpenAPI doc.
Test Plan
Added a unit test for duplicates.