Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] SOAR-0011: Improved error handling #626

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

gayathrisairam
Copy link

Motivation

Swift OpenAPI runtime doesn't allow for fine grained error handling. This PR adds a proposal for improved error handling in Swift OpenAPI runtime.

Modifications

  • Add SOAR-011: Improved error handling.
    (See the proposal for details)

Result

n/a

Test Plan

n/a

@czechboy0
Copy link
Collaborator

Please also add a link to it in the Proposals.md file 🙂

Copy link
Collaborator

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @gayathrisairam!

Added a few comments that are meant to help prepare the proposal for review (I'll hold off on commenting on the proposal itself for the review period).

Once you make these updates, we'll be able to send out the proposal for wider review.

@simonjbeaumont simonjbeaumont added kind/proposal Proposals for review. labels Sep 17, 2024
@gayathrisairam
Copy link
Author

Please also add a link to it in the Proposals.md file 🙂

Link to what?

@czechboy0
Copy link
Collaborator

Please also add a link to it in the Proposals.md file 🙂

Link to what?

Here, a link to your proposal:

@czechboy0 czechboy0 changed the title Proposal for error handling [Proposal] SOAR-0011: Improved Error Handling Sep 19, 2024
@czechboy0 czechboy0 changed the title [Proposal] SOAR-0011: Improved Error Handling [Proposal] SOAR-0011: Improved error handling Sep 19, 2024
@czechboy0
Copy link
Collaborator

The proposal is now In Review, forums thread: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736

@czechboy0
Copy link
Collaborator

This proposal is now Ready for Implementation, see details on the forums: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736/31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Proposals for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants