Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve 5.3 docker setup #214

Merged
merged 1 commit into from
May 5, 2020
Merged

improve 5.3 docker setup #214

merged 1 commit into from
May 5, 2020

Conversation

tomerd
Copy link
Member

@tomerd tomerd commented May 5, 2020

motivation: pin to 5.3 nighties

changes: use swiftlang/swift:nightly-5.3-master-bionic instead of swiftlang/swift:nightly-master-bionic

motivation: pin to 5.3 nighties 

changes: use swiftlang/swift:nightly-5.3-master-bionic instead of swiftlang/swift:nightly-master-bionic
@tomerd tomerd requested a review from Lukasa May 5, 2020 05:24
@tomerd
Copy link
Member Author

tomerd commented May 5, 2020

@swift-nio-bot test this please

1 similar comment
@tomerd
Copy link
Member Author

tomerd commented May 5, 2020

@swift-nio-bot test this please

@Lukasa Lukasa added the semver/patch No public API change. label May 5, 2020
@Lukasa Lukasa added this to the 2.8.0 milestone May 5, 2020
@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2020

5.3 failed due to known NIO issue, ignoring that.

@tomerd
Copy link
Member Author

tomerd commented May 5, 2020

hmm this test seem have been hung on both 5.0 and 5.2, not sure if a known issue?

00:03:39.743 Test Case 'NIOSSLIntegrationTest.testNewCallbackCanDelayHandshake' started at 2020-05-05 06:09:31.372

@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2020

Build timeouts on the rest, probably congestion on the builder.

@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2020

@swift-nio-bot test this please

@Lukasa Lukasa merged commit 67303bd into master May 5, 2020
@Lukasa Lukasa deleted the tomerd-patch-2 branch May 5, 2020 07:49
@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2020

Yup, known issue, filed as #197.

@Lukasa Lukasa modified the milestones: 2.8.0, 2.7.2 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants