Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASI platform build issue #291

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix WASI platform build issue #291

merged 1 commit into from
Oct 30, 2024

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Oct 30, 2024

Close #290

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a fine change, though I'll note that while this builds on wasi it still will not run.

@Lukasa Lukasa added the semver/patch No public API change. label Oct 30, 2024
@Lukasa Lukasa enabled auto-merge (squash) October 30, 2024 13:32
@Lukasa Lukasa merged commit 06dc63c into apple:main Oct 30, 2024
32 of 35 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/wasi branch October 30, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest 3.9.0 release is breaking the WASI build
2 participants