XCTAssertUnorderedEqualSequences
: Improve algorithmic complexity when elements are Hashable
(Resolves #176)
#177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #176
When the elements of a sequence are
Hashable
, use aDictionary
to keep track of the counts of elements.The performance depends upon the input, but consistently performs better in large sequences.
For the unit tests that this is used in, the performance wouldn’t be noticeable since it’s only ever working with small collections. However, we can probably move this to a new function that is useful outside of XCTest, like
elementsEqual
is toXCTAssertEqualSequences
.Checklist