loadbalancer-experimental: subscribe is the last thing we do in DefaultLB constructor #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltLB constructor Motivation: We want all the fields initialized before we subscribe to the SD events so if something happens and an attempt is made to close before construction is complete we don't end up with a NPE somewhere. Modifications: - Move the outlier detection stream cancellation assignment to before the subscription. Result: What is the result of this change?
idelpivnitskiy
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want all the fields initialized before we subscribe to the SD events so if something happens and an attempt is made to close before construction is complete we don't end up with a NPE somewhere.
Modifications: