Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SPICE-0009 External Readers #660

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Implement SPICE-0009 External Readers #660

merged 15 commits into from
Oct 29, 2024

Commits on Oct 26, 2024

  1. Refactor message-passing logic into pkl-core 

    This is preparatory work for [SPICE-0009](apple/pkl-evolution#10).
It is being contributed in a separate pull request to ease review.

The Message, Message(En|De)coder, and MessageTransport types have been ported to Java and moved to a new `org.pkl.core.messaging` package.
    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    426237a View commit details
    Browse the repository at this point in the history

  2. Split server-specific messages/encoding/decoding back into pkl-server

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    dd29012 View commit details
    Browse the repository at this point in the history

  3. Implement SPICE-0009 External Readers 

    [SPICE-0009](apple/pkl-evolution#10)

New close flow
    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    d27908b View commit details
    Browse the repository at this point in the history

  4. docs

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    472b89d View commit details
    Browse the repository at this point in the history

  5. Add ExternalReaderRuntime, lots of test coverage

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    42ce6f0 View commit details
    Browse the repository at this point in the history

  6. Add doc comments to new public APIs

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    4f5a72d View commit details
    Browse the repository at this point in the history

  7. Improve backcompat for new language binding libs on old pkl versions 

    Box Bytes, fix error CLI handling during project load

Bytes equals compare
    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b50f801 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Daniel Chao <[email protected]>

Apply suggestions from code review

Co-authored-by: Daniel Chao <[email protected]>

Rename --external-* CLI flags to --external-*-reader

Rename ExternalProcess -> ExternalReaderProcess

Add org.pkl.core.util.Readers.closeQuietly and deprecate ModuleReaders.closeQuietly

Clean up doc comments

Refactor ExternalReaderRuntime into pkl-config-java

Refactor out External*Resolver classes, rename ResourceReaders.ExternalDelegate and ModuleKeys.External to MessageTransport
    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b5b6a59 View commit details
    Browse the repository at this point in the history

  9. Address review feedback

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    ff3f1e0 View commit details
    Browse the repository at this point in the history

  10. Use records for message types

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    d772e5c View commit details
    Browse the repository at this point in the history

  11. Update message type codes

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    13cee73 View commit details
    Browse the repository at this point in the history

  12. Update naming for resource readers, module key + factory; Move extern… 

    …al resolvers into module/resource packages
    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    dae7394 View commit details
    Browse the repository at this point in the history

  13. integrate changes from rebase

    @HT154
    HT154 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    2efb4c2 View commit details
    Browse the repository at this point in the history

  14. Update Strings.kt 

    Co-authored-by: Islon Scherer <[email protected]>
    @HT154 @stackoverflow
    HT154 and stackoverflow committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    205d859 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Remove Bytes indirection 

    Work around weird kt interop issue
    @HT154
    HT154 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e3f777a View commit details
    Browse the repository at this point in the history