Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create documentation for all pkl releases #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create documentation for all pkl releases #30

wants to merge 1 commit into from

Conversation

shenson
Copy link
Contributor

@shenson shenson commented Aug 30, 2024

No description provided.

bioball
bioball requested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our conversation: this doesn't work so well for us because it means we can't update our documentation without creating a new release.

Also, because patch releases don't include new features, there's not that much utility in keeping around docs for every patch release.

However, an improvement here is to have a link for each minor version, e.g. have a link at /main/0.26/index.html instead of /main/0.26.3/index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bioball bioball bioball requested changes

@holzensp holzensp holzensp approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenson @holzensp @bioball