bugfix: updated scaling factor for SDXL #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseemw
approved these changes
Nov 13, 2023
pcuenca
approved these changes
Nov 26, 2023
| latents = 1 / 0.18215 * latents | ||
|
|
||
| if self.xl: | ||
| scaling_factor =0.13025 |
There was a problem hiding this comment.
Suggested change
| scaling_factor =0.13025 | |
| scaling_factor = 0.13025 |
|
any chance this is getting merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the scale factor for SDXL. Using the prior scale factor results in hazy images. Updated scale factor is from https://huggingface.co/stabilityai/stable-diffusion-xl-base-1.0/blob/main/vae/config.json
with updated scale factor (0.13025):
with prior scale factor (0.18215):
Thank you for your interest in contributing to Core ML Stable Diffusion! Please review CONTRIBUTING.md first. If you would like to proceed with making a pull request, please indicate your agreement to the terms outlined in CONTRIBUTING.md by checking the box below. If not, please go ahead and fork this repo and make your updates.
We appreciate your interest in the project!
Do not erase the below when submitting your pull request:
#########