Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use incentives native tokens structs in staking impl #162

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

ApolloGie
Copy link
Contributor

Tests will be completed later. Let me know if I need to move this to the cw-dex package. I can't remember which is being deprecated.

@ApolloGie ApolloGie force-pushed the feat/support-native-lp-tokens branch from 1d74fb7 to a033ee7 Compare April 30, 2024 23:41
Copy link
Contributor

@apollo-sturdy apollo-sturdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
@pacmanifold
Copy link
Contributor

Lets also bump cosmwasm-std to 1.5.4 since there is an overflow bug in 1.5.3

@ApolloGie ApolloGie force-pushed the feat/support-native-lp-tokens branch from a033ee7 to 6425784 Compare May 1, 2024 13:44
cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
cw-dex-astroport/src/staking.rs Outdated Show resolved Hide resolved
@ApolloGie ApolloGie force-pushed the feat/support-native-lp-tokens branch from 6425784 to 6ccda69 Compare May 1, 2024 13:58
@pacmanifold pacmanifold force-pushed the feat/support-native-lp-tokens branch from 6ccda69 to 2155779 Compare May 1, 2024 15:18
Copy link
Contributor

@pacmanifold pacmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. now all we need is to update cw-it to an rc version using astroport v5 and copy all tests in cw-dex-astroport to also run against v5 pools

@ApolloGie ApolloGie marked this pull request as ready for review May 12, 2024 12:05
@apollo-sturdy apollo-sturdy merged commit 4ee80b7 into develop Aug 28, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants