Release 0.4.0 #32
Release 0.4.0 #32
Conversation
pacmanifold
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
===========================================
+ Coverage 0.43% 17.24% +16.80%
===========================================
Files 8 6 -2
Lines 685 4959 +4274
===========================================
+ Hits 3 855 +852
- Misses 682 4104 +3422 ☔ View full report in Codecov by Sentry. |
Cargo.toml
Outdated
| @@ -34,11 +34,11 @@ panic = 'abort' | |||
| rpath = false | |||
|
|
|||
| [features] | |||
| default = [] | |||
| default = ["astroport", "osmosis"] | |||
There was a problem hiding this comment.
then Pool becomes empty and a bunch of issues pop up. you need to actually compile it with either one of the features (otherwise there is no functionality) but I didn't find a good way to force compilation with at least one of the features
There was a problem hiding this comment.
In vault zapper I tried doing:
// Force selecting either `astroport` or `osmosis` features, or both.
#[cfg(not(any(feature = "astroport", feature = "osmosis")))]
compile_error!("Must select either `astroport` or `osmosis` feature, or both");But, unfortunately abstractmoney/rust-optimizer tries to compile one version without features so fails CI.
| @@ -40,7 +40,7 @@ set -eux | |||
|
|
|||
| grcov ${COVERAGE_PROF_OUTPUT} \ | |||
| -b ${COVERAGE_BINARIES} -s ${CARGO_MAKE_WORKSPACE_WORKING_DIRECTORY} \ | |||
| -t ${GRCOV_OUTPUT_TYPE} --llvm --branch --ignore-not-existing --ignore "/*" --ignore "*/tests/*" --ignore "*/testing/*" --ignore "target/*" --ignore "contracts/swapper/mock/*" --ignore "contracts/swapper/osmosis/*" -o ${GRCOV_OUTPUT_PATH} | |||
| -t ${GRCOV_OUTPUT_TYPE} --llvm --branch --ignore-not-existing --ignore "tests/osmosis_tests.rs" -o ${GRCOV_OUTPUT_PATH} | |||
There was a problem hiding this comment.
why ignore osmosis tests?
There was a problem hiding this comment.
they all run against OsmosisTestApp so can't run coverage on them
There was a problem hiding this comment.
Ah. Maybe open an issue to generalize the tests to use generic test runner?
No description provided.