-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add integration tests for storages, proxy configuration #49
Conversation
assert list_page.items[-1]['id'] == desired_item_count - 1 | ||
|
||
|
||
class TestActorOpenDataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test if open works for the dataset name and as you pass ID, we probably didn't test this in unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test it with names in unit tests. https://github.com/apify/apify-sdk-python/blob/master/tests/unit/actor/test_actor_dataset.py#L22-L25
from .conftest import ActorFactory | ||
|
||
|
||
class TestActorOpenKeyValueStore: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I would test with name and ID param.
from .conftest import ActorFactory | ||
|
||
|
||
class TestActorOpenRequestQueue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I would test with name and ID param.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I had a few comments, plus I agree with Kuba's comments about testing the named storages.
rq1 = await Actor.open_request_queue() | ||
rq2 = await Actor.open_request_queue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also check the RequestQueue
class functionality a bit, so that we know it works on the platform.
So:
I found out some problems with datetimes, specifically |
I am open to suggestions for more tests or some more complicated cases.
We should also think if running the/same similar code in unit and integration tests has some value or not.