Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update titles of python templates #293

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Sep 12, 2024

it should be (more) in accordance with the JS templates

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Sep 12, 2024
@vdusek vdusek added this to the 98th sprint - Tooling team milestone Sep 12, 2024
@vdusek vdusek self-assigned this Sep 12, 2024
@vdusek vdusek merged commit 223908d into master Sep 12, 2024
15 of 16 checks passed
@vdusek vdusek deleted the update-python-templates branch September 12, 2024 13:14
@@ -219,7 +219,7 @@
{
"id": "python-crawlee-playwright",
"name": "python-crawlee-playwright",
"label": "Start with Python Crawlee and Playwright",
"label": "Crawlee + Playwright + Chrome",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the template is using chromium now, right? 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Feel free to open an issue to straighten that up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants