Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1887] SI: Add tag to allow forcible app creation #99

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Jul 28, 2023

What is this PR for?

Applications can be created in response to existing allocations
being reported from the shim to the core. We need to ensure that
these applications are not rejected.

Also update comment around AllocationRequest.Allocations to
reflect correct semantics.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1887

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Applications can be created in response to existing allocations
being reported from the shim to the core. We need to ensure that
these applications are not rejected.
@craigcondit craigcondit changed the title [YUNIKORN-1887] SI: Add tag for application recovered flag [YUNIKORN-1887] SI: Add tag to allow forcible app creation Jul 28, 2023
Copy link
Contributor

@manirajv06 manirajv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@craigcondit craigcondit deleted the YUNIKORN-1887 branch July 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants