Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2585] SI: Convert AllocationID to AllocationKey #138

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2585] SI: Convert AllocationID to AllocationKey #138

wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Now that AllocationID and AllocationKey represent the same data, use AllocationKey consistently within the scheduler interface.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2585

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Apr 24, 2024
chia7712
chia7712 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigcondit craigcondit marked this pull request as draft April 24, 2024 20:34
pbacsko
pbacsko approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@craigcondit craigcondit marked this pull request as ready for review April 25, 2024 18:29
@craigcondit craigcondit deleted the YUNIKORN-2585 branch April 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbacsko pbacsko pbacsko approved these changes

@chia7712 chia7712 chia7712 approved these changes

@manirajv06 manirajv06 Awaiting requested review from manirajv06

@wilfred-s wilfred-s Awaiting requested review from wilfred-s

Assignees

@craigcondit craigcondit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcondit @chia7712 @pbacsko