Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2204] Use ask unique id for allocation #111

Closed
wants to merge 1 commit into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

Rename allocation uuid to allocationID

What type of PR is it?

  • - Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2204

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 self-assigned this Nov 29, 2023
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too much change in the generated proto files.
This has happened to me once some months ago. I had no desire to figure out why, so just cloned the SI repo again, which solved the problem... :)

// the applicationID
string UUID = 3;
string allocationID = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the change we did for groupID and reason: we reserve the ID and name for backwards compatibility

@manirajv06
Copy link
Contributor Author

Closing as this would be taken care by https://issues.apache.org/jira/browse/YUNIKORN-2211

@manirajv06 manirajv06 closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants