Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepeatEndStep has the same treatment as EndStep under ComputerAwareStep #2879

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

rdtr
Copy link
Contributor

@rdtr rdtr commented Nov 1, 2024

RepeatEndStep has the same treatment as EndStep under ComputerAwareStep

@rdtr rdtr changed the base branch from master to 3.7-dev November 1, 2024 22:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (9b46b67) to head (20486a3).
Report is 270 commits behind head on 3.7-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #2879      +/-   ##
=============================================
+ Coverage      76.14%   76.43%   +0.29%     
- Complexity     13152    13228      +76     
=============================================
  Files           1084     1060      -24     
  Lines          65160    61491    -3669     
  Branches        7285     7336      +51     
=============================================
- Hits           49616    47001    -2615     
+ Misses         12839    11971     -868     
+ Partials        2705     2519     -186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cole-Greer
Copy link
Contributor

LGTM VOTE +1

@xiazcy
Copy link
Contributor

xiazcy commented Nov 4, 2024

VOTE + 1

@kenhuuu
Copy link
Contributor

kenhuuu commented Nov 6, 2024

VOTE +1

@rdtr
Copy link
Contributor Author

rdtr commented Nov 7, 2024

Looks like ready to merge ?

@xiazcy xiazcy merged commit 53270ca into apache:3.7-dev Nov 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants