Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-435][PART-B] Fix typo in trace constant "contant -> constant". #443

Merged
merged 1 commit into from
Oct 25, 2022
Merged

[ISSUE-435][PART-B] Fix typo in trace constant "contant -> constant". #443

merged 1 commit into from
Oct 25, 2022

Conversation

BeautyyuYanli
Copy link
Contributor

@BeautyyuYanli BeautyyuYanli commented Sep 23, 2022

What is the purpose of the change

Fix typo: contant -> constant

Brief changelog

  • replace Contant with Constant
  • rename file src/trace/TraceContant.cpp as src/trace/TraceConstant.cpp
  • rename file src/trace/TraceContant.h as src/trace/TraceConstant.h

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing changed the title Fix typo: contant -> constant [ISSUE-435][PART-B] Fix typo in trace constant "contant -> constant". Sep 27, 2022
@ShannonDing
Copy link
Member

link #435

@ShannonDing ShannonDing merged commit 04ab685 into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants