Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-435][PART-A]Support receiving traceOn signal. #434

Merged
merged 4 commits into from
Aug 12, 2022
Merged

[ISSUE-435][PART-A]Support receiving traceOn signal. #434

merged 4 commits into from
Aug 12, 2022

Conversation

BeautyyuYanli
Copy link
Contributor

@BeautyyuYanli BeautyyuYanli commented Jul 30, 2022

What is the purpose of the change

Relate to #435

Support receiving traceOn signal, which indicates whether to disable message trace.

Brief changelog

  • add interface SendResult::getTraceOn()
  • complete extFields according to this

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added enhancement New feature or request SoC Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on labels Jul 30, 2022
@ShannonDing ShannonDing changed the title Support receiving traceOn signal [ISSUE-435][PART-A]Support receiving traceOn signal Jul 30, 2022
@ShannonDing ShannonDing changed the title [ISSUE-435][PART-A]Support receiving traceOn signal [ISSUE-435][PART-A]Support receiving traceOn signal. Jul 30, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 5cdb268 into apache:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SoC Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants