Fix KeyManage log when using CLI mode #6372
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, whenever a KeyStore is used (for example for client certificates) in CLI mode, there is a message that no password was provided. This was caused by the else of the condition being on the wrong if statement, and can cause people to spend a lot of time trying to debug why the key store won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, whenever a KeyStore is used (for example for client certificates) in CLI mode, there is a message that no password was provided.
This was caused by the else of the condition being on the wrong if statement, and can cause people to spend a lot of time trying to debug why the key store won't work.
Types of changes
Checklist: