Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo ("IT S" to "ITS") #6296

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

dcoomber
Copy link
Contributor

@dcoomber dcoomber commented Jun 21, 2024

Description

I noted a typo in the console output while recording a test using the HTTP recorder.

I am proposing changing "IT S" to "ITS" in the docs and in KeyToolUtils.java.

Motivation and Context

This is not an important problem with functionality. It is a nitpick. It was cheap to fix and will hopefully be cheap to include in an upcoming version.

How Has This Been Tested?

I haven't tested the change as I am not a Java developer and do not have a development environment setup.

I think that this is okay as I have only updated a string value assignment and documentation.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@vlsi vlsi merged commit 339c793 into apache:master Jun 21, 2024
3 of 7 checks passed
@dcoomber dcoomber deleted the dcoomber-patch-2024-06-21-nitpick branch June 21, 2024 16:51
@FSchumacher
Copy link
Contributor

I think it should be changed to IT IS. its is not the same as it's, which was probably meant to be written.

@vlsi
Copy link
Collaborator

vlsi commented Jun 21, 2024

I thought an apostrophe was there. It should indeed be "it is"

@dcoomber
Copy link
Contributor Author

I'll submit a new PR with a correction in the morning. Apologies for the "own goal", folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants