Misc. improvements #58

ghost · 2017-10-15T02:14:02Z

No description provided.

The use of isEmpty() is generally to be preferred because it is possible for a size() implementation to be slow, but isEmpty() to be fast.

…cessary StringBuilder is generally to be preferred over StringBuffer where synchronization is not necessary. Other efficiency improvements: * Use append(char) when only one character is appended * Chain append() calls rather than append a string concatenation * Append subsequences directly to avoid creating a new object * Re-use StringBuilders rather than create new ones

StrBuilder is like StringBuilder with some extra utility methods that improve the efficiency of certain code that builds strings.

As addListener(), removeListener(), and getListeners() synchronize access to listenerMap and idMap, this appears to be necessary.

Previously, if callback was null, an IllegalArgumentException would be thrown within the try block. This would be caught by the catch (Exception) block which would dereference callback.

dtrebbien added 27 commits October 14, 2017 12:52

Replace use of obsolete Vector collection

f2b7905

Use String.contains()

f8dbd9b

Remove unused variable assignments

8d555ac

Use isEmpty() to check whether a collection is (or isn't) empty

29f5ccc

The use of isEmpty() is generally to be preferred because it is possible for a size() implementation to be slow, but isEmpty() to be fast.

Correct typos

c122cc7

Supply type information

2ca8527

Use enhanced for loops

39ff25f

Remove unnecessary boxing/unboxing

7a3482d

LoggingPrintStream.println() should atomically access/modify its buffer

11d38b5

Correct potentially confusing whitespace indentation

e841984

Use Collections.emptyMap() rather than EMPTY_MAP

8f801da

Delete unused imports

282ddff

Guard against integer overflow

cb5a9c6

LogPrintWriter.println() should atomically access/modify the buffer

4a84ab4

Fields storing cached values should be marked transient

081e61b

Improve indentation

40bbb75

Simplify ChildNodeAttic.remove(NodeEntry)

7fba6ba

Use addAll(Arrays.asList(...)) to add each array element

571b82e

Utilize Commons Lang StrBuilder

65069d0

StrBuilder is like StringBuilder with some extra utility methods that improve the efficiency of certain code that builds strings.

Use StringUtils' null-safe equals() and endsWith()

b16be2e

Don't recompute name.indexOf('[')

cd2217d

Supply type information

748fc81

Synchronize access to listenerMap

8aa798c

As addListener(), removeListener(), and getListeners() synchronize access to listenerMap and idMap, this appears to be necessary.

Fix a NPE if callback is null

bb4e864

Previously, if callback was null, an IllegalArgumentException would be thrown within the try block. This would be caught by the catch (Exception) block which would dereference callback.

Supply type information

778a8f5

Remove unnecessary boxing/unboxing

6090c5f

asfgit force-pushed the trunk branch from b23af0d to 28744d8 Compare October 7, 2019 05:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc. improvements #58

Misc. improvements #58

ghost commented Oct 15, 2017

Misc. improvements #58

Are you sure you want to change the base?

Misc. improvements #58

Conversation

ghost commented Oct 15, 2017