Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepositoryServiceImpl improvements #54

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

RepositoryServiceImpl improvements #54

wants to merge 8 commits into from

Commits on Oct 13, 2017

  1. Replace use of StringBuffer with StringBuilder

    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    4c30360 View commit details
    Browse the repository at this point in the history

  2. Fix potential null dereference

    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    5c20d7f View commit details
    Browse the repository at this point in the history

  3. Replace size() == 0 with isEmpty()

    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    cb21957 View commit details
    Browse the repository at this point in the history

  4. Replace manual addition of array to Collection with addAll(Arrays.asL… 

    …ist(...))
    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    9e46ea2 View commit details
    Browse the repository at this point in the history

  5. Replace use of StringBuffer with StringBuilder

    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    aed60b4 View commit details
    Browse the repository at this point in the history

  6. Delete an extra semicolon that causes "empty statement" warning in Ne… 

    …tBeans
    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    fc6bd79 View commit details
    Browse the repository at this point in the history

  7. Add a return type type parameter to the private Callable interface 

    This allows the compiler to check more at compile time; in particular,
it allows the Java compiler to make sure that every branch within a
Callable implementation returns a value of the correct type.

It also allows some explicit type casts to be removed.
    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    b6aad26 View commit details
    Browse the repository at this point in the history

  8. Replace size() != 0 with !isEmpty()

    @dtrebbien
    dtrebbien committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    f5ce178 View commit details
    Browse the repository at this point in the history