HIVE-28623: Implement RuntimeContext to decouple runtime data from TezTask #5538
Conversation
|
cc: @tanishq-chugh , @ayushtkn |
abstractdog
force-pushed
the
HIVE-28623
branch
from
b4197e7
to
7fe872c
Compare
abstractdog
force-pushed
the
HIVE-28623
branch
from
7fe872c
to
2e4cf68
Compare
asf-ci-hive
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
tests unstable
labels
|
| @@ -125,6 +130,12 @@ public QueryPlan getPlan() { | |||
|
|
|||
| public void setPlan(QueryPlan plan) { | |||
| this.plan = plan; | |||
| TezTask task = Utilities.getFirstTezTask(plan.getRootTasks()).orElse(null); | |||
There was a problem hiding this comment.
@abstractdog After query run completes, when resources are being released by the driver, plan is being set to null and it is causing NullPointerException here, which is present as part of DEBUG logs.
There was a problem hiding this comment.
I see, can you point me to the logs that show this?
btw I made a slight refactor in this area after pushing the original, working version that I used in case of the query history...NPE looks weird as we obtain a reference to the RuntimeContext in setPlan...I guess there are calls when the passed plan is already null, need to null-check I guess
There was a problem hiding this comment.
this shouldn't cause any issue wrt query execution but just some noise in logs. a null check wrt plan should just be fine.. i guess the one test failure in precommit is as well linked to this ;)
What changes were proposed in this pull request?
Encapsulate runtime related info to a separate class for later usage.
Why are the changes needed?
Code refactor.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Easy refactor, precommit tests should pass.