-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a refactoring to simplify prototype reference access #159
Open
timothyjward
wants to merge
10,000
commits into
apache:trunk
Choose a base branch
from
timothyjward:FELIX-5974
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835711 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835720 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835722 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835747 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835748 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835750 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835788 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835793 13f79535-47bb-0310-9956-ffa450edef68
….2.0 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835795 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835797 13f79535-47bb-0310-9956-ffa450edef68
… entry and not if the entry doesn't exist at all. git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835798 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836044 13f79535-47bb-0310-9956-ffa450edef68
…lver. git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836072 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836084 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836098 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836100 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836153 13f79535-47bb-0310-9956-ffa450edef68
…ndrei Tuicu git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836628 13f79535-47bb-0310-9956-ffa450edef68
…ndrei Tuicu git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836629 13f79535-47bb-0310-9956-ffa450edef68
…ndrei Tuicu git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836630 13f79535-47bb-0310-9956-ffa450edef68
…1.0.2 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836695 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836697 13f79535-47bb-0310-9956-ffa450edef68
…nt configuration instances. Apply patch from Tim Ward git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836873 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837113 13f79535-47bb-0310-9956-ffa450edef68
….9.4 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837114 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837116 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837276 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837277 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837279 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837291 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843602 13f79535-47bb-0310-9956-ffa450edef68
…heck-certificate" git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843603 13f79535-47bb-0310-9956-ffa450edef68
…ption when running svn import command. This ensures that svn credentials can be asked if needed. git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843604 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843605 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843606 13f79535-47bb-0310-9956-ffa450edef68
…ter as Preprocessor with the whiteboard (patch provided by Antonio Sanso - thanks) git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843662 13f79535-47bb-0310-9956-ffa450edef68
…r-1.2.6 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843663 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843665 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843668 13f79535-47bb-0310-9956-ffa450edef68
Signed-off-by: Raymond Auge <[email protected]> git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843781 13f79535-47bb-0310-9956-ffa450edef68
….9.10 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843782 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843784 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843794 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843796 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843926 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844108 13f79535-47bb-0310-9956-ffa450edef68
…ed unexpectedly. Do not instantiate prototype instance in case the component does not have an init method git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844112 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844202 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844262 13f79535-47bb-0310-9956-ffa450edef68
Signed-off-by: Raymond Auge <[email protected]> git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844267 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844269 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844271 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844307 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844308 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844536 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844600 13f79535-47bb-0310-9956-ffa450edef68
This should also Fix FELIX-5974 Signed-off-by: Tim Ward <[email protected]>
Note that I couldn't work out how the SCR tests work. I don't know how things like this are normally tested, and I will need help to supply tests for this change. |
Closing a ComponentContext should release the services that it accesses to avoid a memory leak Signed-off-by: Tim Ward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also Fix FELIX-5974
Signed-off-by: Tim Ward [email protected]