Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Set up CodeQL analysis #206

Merged
merged 1 commit into from
Apr 17, 2024
Merged

chore(ci): Set up CodeQL analysis #206

merged 1 commit into from
Apr 17, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Apr 16, 2024

Platforms affected

All

Motivation and Context

CodeQL scanning in CI can help identify bugs and security issues with the library.

Description

  • Added CodeQL scanning with default options as part of CI.

Testing

  • Ran this in my fork, confirmed that CodeQL results showed up under security scanning (and then resolved several of those issues in a previous PR)

Checklist

  • I've run the tests to see all new and existing tests pass

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (0901c1d) to head (45a3bd1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files          20       20           
  Lines        1147     1147           
=======================================
  Hits         1014     1014           
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 602272f into apache:master Apr 17, 2024
11 checks passed
@dpogue dpogue deleted the codeql branch April 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants