Fix direcotory table problems and add guc allow_dml_directory_table. #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchaozhang-123
force-pushed
the
fix_directory_table
branch
5 times, most recently
from
5871118
to
90b73e8
Compare
gfphoenix78
reviewed
Oct 25, 2024
gpMgmt/bin/gpdirtableload
Outdated
|
|
||
| if self.options.tag: | ||
| qry += "WHERE tag = \'%s\'" % self.options.tag | ||
| qry += ", tag = \'%s\'" % self.options.tag |
There was a problem hiding this comment.
The conditions should be joined by 'AND'. Do we have test cases for these options?
There was a problem hiding this comment.
Fixed, as this tools is independent from kernel, have not added test cases now.
gfphoenix78
reviewed
Oct 25, 2024
gfphoenix78
reviewed
Oct 25, 2024
wenchaozhang-123
force-pushed
the
fix_directory_table
branch
3 times, most recently
from
5b83243
to
c4decda
Compare
wenchaozhang-123
force-pushed
the
fix_directory_table
branch
from
c4decda
to
9f8e334
Compare
In this commit, fix gpdirtable can not specify file name. We can specify file name using two match mode, full match and regex match. Full match using for download one file while regex match using for downloading files in directory. What's more, we add new guc allow_dml_directory_table, which allow us to do dml on directory table's schema table. Lastly, we support a new grammar for drop directory table. We don't remove directory table's directory by default, while we can remove it by using 'with content' keywords in drop directory table grammar, for example: DROP DIRECTORY TABLE dir_table WITH CONTENT; Authored-by: Zhang Wenchao [email protected]
wenchaozhang-123
force-pushed
the
fix_directory_table
branch
from
9f8e334
to
04ef0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, fix gpdirtable can not specify file name. We can specify file name using two match mode, full match and regex match. Full match using for download one file while regex match using for downloading files in directory. What's more, we add new guc allow_dml_directory_table, which allow us to do dml on directory table's schema table. Lastly, we support a new grammar for drop directory table. We don't remove directory table's directory by default, while we can remove it by using 'with content' keywords in drop directory table grammar, for example:
DROP DIRECTORY TABLE dir_table WITH CONTENT;
Authored-by: Zhang Wenchao [email protected]
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳