AIP-84 Fix: Allow Null Values for end_date Field in Dashboard Endpint in FastAPI #44043
+97
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries/endpoints and simplify unittests
bugraoz93
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
bugraoz93
changed the title
bugraoz93
changed the title
tirkarthi
reviewed
Nov 15, 2024
| # DagRuns | ||
| dag_run_types = session.execute( | ||
| select(DagRun.run_type, func.count(DagRun.run_id)) | ||
| .where( | ||
| DagRun.start_date >= start_date, | ||
| func.coalesce(DagRun.end_date, timezone.utcnow()) <= end_date, | ||
| func.coalesce(DagRun.end_date, timezone.utcnow()) <= func.coalesce(end_date, timezone.utcnow()), |
There was a problem hiding this comment.
timezone.utcnow() can be just defined once at the top of the function to avoid different values due to multiple calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #43846
safe_date_timeto returnNoneif the input isNoneNonein queries/endpointsI have created a separate PR because write permissions don't allow me to push to the existing PR.
cc: @bbovenzi @pierrejeambrun @tirkarthi
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.